Avoid race starting SseResponseStreamTransport #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging from https://github.com/modelcontextprotocol/csharp-sdk/actions/runs/14040589658/job/39309497411 indicates that one source of test flakiness is a real product issue.
_sseWriteTaskmight not be set until after the SSE endpoint event has already been sent sinceSseFormatter.WriteAsyncdoes not return a task until it awaits. This means that it's possible for the client to find the "/message" endpoint and send a message to that beforeIsConnectedis true which can lead to an improperInvalidOperationExceptionas seen in the logs.